Ayal Baron has posted comments on this change.
Change subject: core: VmReplicateDiskFinish on SyncImageData failure
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskFinishTaskHandler.java
Line 159: }
Line 160:
Line 161: @Override
Line 162: protected void revertTask() {
Line 163: // Preventing rollback on VmReplicateDiskFinish success
Examining the db is required but insufficient.
You are correct wrt the race and that is why while we're not *sure* we should
not allow to rollback.
Iiuc, the default here is to *yes* allow rollback as long as
VmReplicateDiskFinish did not finish successfully which is not the correct
behaviour.
e.g. If VmReplicateDiskFinish was sent and engine immediately after crashed
(before receiving the response from vdsm) we would rollback, even if on vdsm
side it failed. In this state we would delete the source volume while the VM
is still using it.
Line 164: // (checks whether the disk moved successfully to the target
storage domain)
Line 165: Guid targetStorageDomainId =
getEnclosingCommand().getParameters().getTargetStorageDomainId();
Line 166: Guid destinationImageId =
getEnclosingCommand().getParameters().getDestinationImageId();
Line 167: DiskImage diskImage =
getDiskImageDao().get(destinationImageId);
--
To view, visit http://gerrit.ovirt.org/14722
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c25b02cb0c2bd78b012dd3e3654caa43f5141d6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
