Tal Nisan has posted comments on this change.
Change subject: core: FQCN imports in the vdsbroker project
......................................................................
Patch Set 1: Looks good to me, approved
(3 inline comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IRSGenericException.java
Line 2:
Line 3: import org.ovirt.engine.core.vdsbroker.vdsbroker.VDSExceptionBase;
Line 4:
Line 5: public class IRSGenericException extends VDSExceptionBase implements
java.io.Serializable {
Line 6: // protected IRSGenericException(SerializationInfo info,
StreamingContext
Can also be removed, not necessarily in this patch
Line 7: // context)
Line 8: // {
Line 9: // super(info, context);
Line 10: // }
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ServerConnectionListReturnForXmlRpc.java
Line 3: import java.util.Map;
Line 4:
Line 5: import org.ovirt.engine.core.vdsbroker.irsbroker.StatusReturnForXmlRpc;
Line 6:
Line 7: //-----------------------------------------------------
Likewise
Line 8: //
Line 9: //-----------------------------------------------------
Line 10:
Line 11: public final class ServerConnectionListReturnForXmlRpc extends
StatusReturnForXmlRpc {
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VDSErrorException.java
Line 2:
Line 3: import org.ovirt.engine.core.common.errors.VdcBllErrors;
Line 4:
Line 5: public class VDSErrorException extends VDSGenericException implements
java.io.Serializable {
Line 6: // protected VDSErrorException(SerializationInfo info,
StreamingContext
Likewise ;)
Line 7: // context)
Line 8: // {
Line 9: // super(info, context);
Line 10: // }
--
To view, visit http://gerrit.ovirt.org/14803
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3dab43709c422fa26601cb033e17f1b21bc96f0f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
