Arik Hadas has uploaded a new change for review. Change subject: webadmin: [WIP] add memory column to snapshot subtab ......................................................................
webadmin: [WIP] add memory column to snapshot subtab Add column to the snapshot subtab that contains checkbox which reflects whether the snapshot contains memory state or not. Change-Id: I899ee047bc4fa66e373518eae350cf372b3fd4c6 Signed-off-by: Arik Hadas <[email protected]> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTable.java 2 files changed, 19 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/61/14861/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java index 3c9d64b..42e9d2b 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java @@ -575,6 +575,9 @@ @DefaultStringValue("Status") String statusSnapshot(); + @DefaultStringValue("Memory") + String memorySnapshot(); + @DefaultStringValue("Disks") String disksSnapshot(); diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTable.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTable.java index 8652474..5795eaa 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTable.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTable.java @@ -14,6 +14,7 @@ import org.ovirt.engine.ui.common.widget.renderer.FullDateTimeRenderer; import org.ovirt.engine.ui.common.widget.table.OrderedMultiSelectionModel; import org.ovirt.engine.ui.common.widget.table.SimpleActionTable; +import org.ovirt.engine.ui.common.widget.table.column.CheckboxColumn; import org.ovirt.engine.ui.common.widget.table.column.EnumColumn; import org.ovirt.engine.ui.common.widget.table.column.SafeHtmlColumn; import org.ovirt.engine.ui.common.widget.table.column.TextColumnWithTooltip; @@ -92,7 +93,7 @@ return FullDateTimeRenderer.getLocalizedDateTimeFormat().format(snapshot.getCreationDate()); } }; - getTable().addColumn(dateColumn, constants.dateSnapshot(), "185px"); //$NON-NLS-1$ + getTable().addColumn(dateColumn, constants.dateSnapshot(), "150px"); //$NON-NLS-1$ TextColumnWithTooltip<Snapshot> statusColumn = new EnumColumn<Snapshot, SnapshotStatus>() { @Override @@ -100,7 +101,20 @@ return snapshot.getStatus(); } }; - getTable().addColumn(statusColumn, constants.statusSnapshot(), "95px"); //$NON-NLS-1$ + getTable().addColumn(statusColumn, constants.statusSnapshot(), "75px"); //$NON-NLS-1$ + + CheckboxColumn<Snapshot> memoryColumn = new CheckboxColumn<Snapshot>() { + @Override + public Boolean getValue(Snapshot object) { + return !object.getMemoryVolume().isEmpty(); + } + + @Override + protected boolean canEdit(Snapshot object) { + return false; + } + }; + getTable().addColumn(memoryColumn, constants.memorySnapshot(), "55px"); //$NON-NLS-1$ SafeHtmlColumn<Snapshot> descriptionColumn = new SafeHtmlColumn<Snapshot>() { @Override -- To view, visit http://gerrit.ovirt.org/14861 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I899ee047bc4fa66e373518eae350cf372b3fd4c6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
