Maor Lipchuk has posted comments on this change. Change subject: core: move image group command ......................................................................
Patch Set 6: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveImageGroupCommand.java Line 25: removeImageParams.setEntityId(Guid.NewGuid()); Line 26: removeImageParams.setParentCommand(VdcActionType.RemoveImage); Line 27: removeImageParams.setDbOperationScope(ImageDbOperationScope.NONE); Line 28: //TODO: should be removed as async task manager issues would be resolved, done in order Line 29: // to avoid copy operations on the image to wait for remove operations. It is hard to understand from the comment why we are using new guid for entity How about the following: Setting a new guid to prevent other operations to end the action with the same flow as the remove operation ends, since the ATM implementation today, determined which end action to run by picking a random task from the tasks list related to the entity id, and it can't be sure which task it will pick to determined which operation to run. This should be changed to entity id, as soon the ATM will change this behaviour. Line 30: removeImageParams.setEntityId(Guid.NewGuid()); Line 31: VdcReturnValueBase returnValue = getBackend().runInternalAction( Line 32: VdcActionType.RemoveImage, Line 33: removeImageParams, -- To view, visit http://gerrit.ovirt.org/13042 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9068d66df3986c9bb16b266bb5bef396964a706 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
