Yair Zaslavsky has posted comments on this change.
Change subject: core: Adds custom properties to VmDevice
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/CustomPropertiesUtils.java
Line 70:
Line 71: private Map<Version, Map<String, Pattern>> predefinedProperties;
Line 72: private Map<Version, Map<String, Pattern>> userdefinedProperties;
Line 73: private Map<Version, String> allVmProperties;
Line 74:
+1 on your comment.
Martin, maybe we should have a base utility class here, and have
VmDeviceProperties and CustomProperties extend it?
Line 75: /**
Line 76: * Prefix for device type definition
Line 77: */
Line 78: private static final String TYPE_PREFIX_STR = "\\{type=(";
....................................................
File
backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/DeviceCustomPropertiesValueHelper.java
Line 16: boolean result = true;
Line 17: String errMsg = null;
Line 18:
Line 19: // HACK, because ConfigValues are not loaded inside
engine-config
Line 20: Version version = new Version(key.getVersion());
I agree, since engine-config depends on utils, we can use the FeatureSupported
class .
Line 21: if (Version.v3_3.compareTo(version) > 0) {
Line 22: result = false;
Line 23: errMsg = String.format("Device custom properties are not
supported in version %s", version.toString());
Line 24: }
--
To view, visit http://gerrit.ovirt.org/14814
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I07daa5cccbf8e3cbd6b4191bbc8ebf0729d9d9a0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
