Yair Zaslavsky has posted comments on this change.
Change subject: foreman integration - showing foreman hosts in new host dialog
......................................................................
Patch Set 9: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java
Line 78: }
Line 79:
Line 80: @Override
Line 81: public List<VDS> getFiltered(String filter) {
Line 82: HttpMethod method = new GetMethod(hostProvider.getUrl() +
"/api/hosts" + (filter.isEmpty()? StringUtils.EMPTY : "?&search=" + filter) +
"&format=json");
Would be awesome to use some constants here - for &search=
&fornat=json
/api/hosts
Thanks!
Line 83: return runHostListMethod(method);
Line 84: }
Line 85:
Line 86: @Override
--
To view, visit http://gerrit.ovirt.org/14582
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30ea180e477a8f0714c4dc97ec55f29be515723a
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
