Maor Lipchuk has posted comments on this change. Change subject: core: Removing template with disks ends with unused data in the db ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (2 inline comments) .................................................... Commit Message Line 5: CommitDate: 2013-05-20 11:41:39 +0300 Line 6: Line 7: core: Removing template with disks ends with unused data in the db Line 8: Line 9: When removing a template, the records of it's disks weren't deleted from /s/it's/its Line 10: base_disk table because the call to the delete stored procedure was done Line 11: with the id of the image rather then the id of the disk - which caused Line 12: to unused records to be left in the table and possible errors when Line 13: trying to import the template again (not as a clone). Line 6: Line 7: core: Removing template with disks ends with unused data in the db Line 8: Line 9: When removing a template, the records of it's disks weren't deleted from Line 10: base_disk table because the call to the delete stored procedure was done /s/delete/deleted Line 11: with the id of the image rather then the id of the disk - which caused Line 12: to unused records to be left in the table and possible errors when Line 13: trying to import the template again (not as a clone). Line 14: -- To view, visit http://gerrit.ovirt.org/14877 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86573e91885085bcdfc30ee4e966590901a62067 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
