Maor Lipchuk has posted comments on this change.
Change subject: core: wip: handle failed import of template
......................................................................
Patch Set 4: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskImagesValidator.java
Line 52: * @return A {@link ValidationResult} with the validation
information.
Line 53: */
Line 54: public ValidationResult diskImagesAlreadyExist() {
Line 55:
Line 56: List<String> existingDisksAliases = new ArrayList<String>();
can use ArrayList<>()
Line 57: for (DiskImage diskImage : diskImages) {
Line 58: if (isDiskExists(diskImage.getId())) {
Line 59: existingDisksAliases.add(diskImage.getDiskAlias());
Line 60: }
--
To view, visit http://gerrit.ovirt.org/14839
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If90414b6c50d922b510a10e20e0774bdbec9c05b
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
