Ori Liel has uploaded a new change for review. Change subject: restapi: Disable Get Groups For Non-Admin User ......................................................................
restapi: Disable Get Groups For Non-Admin User Getting Groups for non-admin user is wrongly implemented. It currently returns - instead of all groups which the user is authorized to see - exactly one User entity, (the user himself). Needless to say this is very far from the intended result. Until new implementation will be avaliable, I am removing this wrong implementation. For now the outcome will now be: user will fail due to insufficient permission. Change-Id: I932a197271ccfa52418276ec4ddfb4c5db95e0a0 Signed-off-by: Ori Liel <[email protected]> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResource.java 1 file changed, 1 insertion(+), 8 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/94/14894/1 diff --git a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResource.java b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResource.java index 1441188..29dcc16 100644 --- a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResource.java +++ b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResource.java @@ -9,10 +9,7 @@ import org.ovirt.engine.core.common.action.AddUserParameters; import org.ovirt.engine.core.common.action.VdcActionType; import org.ovirt.engine.core.common.businessentities.LdapGroup; -import org.ovirt.engine.core.common.businessentities.DbUser; import org.ovirt.engine.core.common.interfaces.SearchType; -import org.ovirt.engine.core.common.queries.VdcQueryParametersBase; -import org.ovirt.engine.core.common.queries.VdcQueryType; public class BackendGroupsResource extends BackendGroupsResourceBase implements GroupsResource { @@ -26,11 +23,7 @@ @Override public Groups list() { - if (isFiltered()) { - return mapDbGroupsCollection(getBackendCollection(DbUser.class, VdcQueryType.GetAllDbUsers, new VdcQueryParametersBase())); - } else { - return mapDbGroupsCollection(getGroupsCollection(SearchType.DBUser, getSearchPattern())); - } + return mapDbGroupsCollection(getGroupsCollection(SearchType.DBUser, getSearchPattern())); } @Override -- To view, visit http://gerrit.ovirt.org/14894 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I932a197271ccfa52418276ec4ddfb4c5db95e0a0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
