Yair Zaslavsky has posted comments on this change. Change subject: packaging: doc: document dao tests ......................................................................
Patch Set 1: Looks good to me, approved (1 inline comment) .................................................... File README.developer Line 169: Line 170: $ make BUILD_TEST_FLAGS="-P enable-dao-tests \ Line 171: -D engine.db.username=engine \ Line 172: -D engine.db.password=engine \ Line 173: -D engine.db.url=jdbc:postgresql://localhost/engine_dao" I think most developers are used to the convention of engine_test. Not that critical, though. It's really up to you if u want to keep it this way or not. Line 174: Line 175: RPM PACKAGING Line 176: Line 177: $ make dist -- To view, visit http://gerrit.ovirt.org/14901 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc5280b2d202f2efa55c8db67bc8a769207ff576 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
