Alona Kaplan has posted comments on this change.
Change subject: webadmin: Houskeeping in Provider main tab and popup
......................................................................
Patch Set 5: Looks good to me, approved
(1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java
Line 86: Provider provider = new Provider();
Line 87: provider.setName((String) privateName.getEntity());
Line 88: provider.setDescription((String)
privateDescription.getEntity());
Line 89: provider.setUrl((String) privateUrl.getEntity());
Line 90:
Please remove trailing whitespace.
Line 91: startProgress(null);
Line 92: Frontend.RunAction(VdcActionType.AddProvider, new
ProviderParameters(provider),
Line 93: new IFrontendActionAsyncCallback() {
Line 94:
--
To view, visit http://gerrit.ovirt.org/14693
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie5d4225174e733588010a46325674df2165c8814
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
