Yair Zaslavsky has posted comments on this change.
Change subject: engine : Change CreateAllSnapshotsFromVmCommand to persist all
placeholders
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
Line 96:
Line 97: Map<Guid, CommandBase<?>> diskIdsToCommandMap = new HashMap<>();
Line 98:
Line 99: @Override
Line 100: protected void insertAsyncTaskPlaceHolders() {
What about overriding the buildXXX method you introduced at previous patch?
Wouldn't this turn the code into more elegant?
Line 101: Guid vmSnapshotId = Guid.NewGuid();
Line 102: for (DiskImage image : getDisksList()) {
Line 103: diskIdsToCommandMap.put(image.getImageId(),
Line 104: constructCommand(VdcActionType.CreateSnapshot,
--
To view, visit http://gerrit.ovirt.org/14841
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f9524667922b99bfe47fc3659f7969efef72996
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
