Kanagaraj M has posted comments on this change.

Change subject: gluster: Update gluster hook content during sync
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHookSyncJob.java
Line 224:         List<Pair<GlusterHookEntity, VDSReturnValue>> pairResults = 
ThreadPoolUtil.invokeAll(contentTasksList);
Line 225: 
Line 226:         for (Pair<GlusterHookEntity, VDSReturnValue> pairResult: 
pairResults) {
Line 227:             final GlusterHookEntity hook = pairResult.getFirst();
Line 228:             final String content = 
(String)pairResult.getSecond().getReturnValue();
vds command failure should be handled here.
Line 229:             getHooksDao().updateGlusterHookContent(hook.getId(), 
hook.getChecksum(), content);
Line 230:         }
Line 231: 
Line 232:     }


--
To view, visit http://gerrit.ovirt.org/14773
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7c951f9c370b49557d7ca037185b098fa869fde
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to