Alona Kaplan has posted comments on this change.

Change subject: webadmin: Added Data Centers node in system tree
......................................................................


Patch Set 7: Looks good to me, approved

(1 inline comment)

....................................................
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/tree/SystemTreeItemCell.java
Line 40:         case DataCenter:
Line 41:             imageResource = applicationResources.dataCenterImage();
Line 42:             break;
Line 43:         case DataCenters:
Line 44:             imageResource = applicationResources.dataCenterImage();
Please provide explicit image for dcs, shouldn't be the same image as for dc.
Line 45:             break;
Line 46:         case Cluster_Gluster:
Line 47:             imageResource = applicationResources.glusterClusterImage();
Line 48:             break;


--
To view, visit http://gerrit.ovirt.org/14759
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I26665a6bb2d12b0e19567002d685d9821d15f53c
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to