Alona Kaplan has posted comments on this change.
Change subject: webadmin: Added Providers to system tree
......................................................................
Patch Set 7: (4 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java
Line 591: networkList.setIsAvailable(model.getType() ==
SystemTreeItemType.Network
Line 592: || model.getType() == SystemTreeItemType.Networks
Line 593: || model.getType() == SystemTreeItemType.System ||
model.getType() == SystemTreeItemType.DataCenter
Line 594: || model.getType() == SystemTreeItemType.Cluster ||
model.getType() == SystemTreeItemType.Host
Line 595: || model.getType() == SystemTreeItemType.Provider);
Why just the network tab?
Line 596:
Line 597: providerList.setIsAvailable(model.getType() ==
SystemTreeItemType.System
Line 598: || model.getType() == SystemTreeItemType.Providers ||
model.getType() == SystemTreeItemType.Provider);
Line 599:
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java
Line 353: @SuppressWarnings("unchecked")
Line 354: @Override
Line 355: public void onSuccess(Object model, Object returnValue) {
Line 356: setProviders((List<Provider>) ((VdcQueryReturnValue)
returnValue).getReturnValue());
Line 357: AsyncDataProvider.getDataCenterList(dcQuery);
Why don't you do it parallel to the dcQuery?
Line 358: }
Line 359: };
Line 360: Frontend.RunQuery(VdcQueryType.GetAllProviders, new
VdcQueryParametersBase(), providersQuery);
Line 361: }
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/tree/SystemTreeItemCell.java
Line 78: break;
Line 79: case Networks:
Line 80: imageResource = applicationResources.networksTreeImage();
Line 81: break;
Line 82: case Provider:
Please substitute with the correct image.
Line 83: imageResource = applicationResources.networkTreeImage();
Line 84: break;
Line 85: case Providers:
Line 86: imageResource = applicationResources.networksTreeImage();
Line 82: case Provider:
Line 83: imageResource = applicationResources.networkTreeImage();
Line 84: break;
Line 85: case Providers:
Line 86: imageResource = applicationResources.networksTreeImage();
Same.
Line 87: break;
Line 88:
Line 89: default:
Line 90: imageResource = applicationResources.questionMarkImage();
--
To view, visit http://gerrit.ovirt.org/14760
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I89c79d2789b1e6058c77404639f6c8b90f82d2a6
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
