Alona Kaplan has posted comments on this change.
Change subject: webadmin: Added connectivity test to provider popup
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ProviderPopupView.java
Line 144:
Line 145: @Override
Line 146: public void setTestResultImage(boolean succeeded) {
Line 147: testResultImage.setResource(succeeded ?
resources.logNormalImage() : resources.logErrorImage());
Line 148: testResultImage.setStyleName(style.testResultImageStyle());
Why don't you do it in the ctor? Why do you need to set the style each time the
image it set?
Line 149: }
--
To view, visit http://gerrit.ovirt.org/14920
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id0856c12d016c283a90c35622441fadc785c5d9c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
