Alona Kaplan has posted comments on this change. Change subject: add and use GetProvidersByType ......................................................................
Patch Set 8: Looks good to me, but someone else must approve (1 inline comment) .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java Line 357: setProviders((List<Provider>) ((VdcQueryReturnValue) returnValue).getReturnValue()); Line 358: AsyncDataProvider.getDataCenterList(dcQuery); Line 359: } Line 360: }; Line 361: Frontend.RunQuery(VdcQueryType.GetAllProviders, new GetAllProvidersParameters(), providersQuery); Why don't you use AsyncDataProvider.GetAllProviders(providersQu ery); ? Line 362: } Line 363: Line 364: @Override Line 365: public void executeCommand(UICommand command) -- To view, visit http://gerrit.ovirt.org/14774 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87ef591a2470726cebef142e72eaee28103c81fd Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
