Sandro Bonazzola has posted comments on this change.
Change subject: packaging: setup: fix otopi implementation version locking
handling
......................................................................
Patch Set 5: (3 inline comments)
....................................................
File packaging/setup/plugins/ovirt-engine-setup/core/uninstall.py
Line 69: osetupcons.CoreEnv.LINES_GROUP_PREFIX + group
Line 70: ].update({
Line 71: 'name': filename,
Line 72: 'lines': lines,
Line 73: })
Done
Line 74:
Line 75:
Line 76: @util.export
Line 77: class Plugin(plugin.PluginBase):
Line 134: )
Line 135: config.set(
Line 136: section,
Line 137: prefix + '.content',
Line 138: content,
I'm not sure I've understood your question, however there was a bug here that
will have overwritten entries adding more than one file in the section. Fixed.
Line 139: )
Line 140:
Line 141: _addFiles(
Line 142: osetupcons.Const.FILE_GROUP_SECTION_PREFIX + 'core',
....................................................
File packaging/setup/plugins/ovirt-engine-setup/distro-rpm/versionlock.py
Line 71: group='versionlock',
Line 72: description='YUM version locking configuration',
Line 73: optional=False
Line 74: )
Line 75: group.addFiles('versionlock', uninstall_files)
Done
Line 76: group.addLines(
Line 77: 'versionlock',
Line 78: osetupcons.FileLocations.OVIRT_ENGINE_YUM_VERSIONLOCK,
Line 79: '\n'.join(content).format(
--
To view, visit http://gerrit.ovirt.org/14700
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1b9142088cfa7def37f6d1ad3d2a4204aebe8ae
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
