Sandro Bonazzola has posted comments on this change.

Change subject: packaging: setup: allow interactive PKI cleanup
......................................................................


Patch Set 8: Fails

(1 inline comment)

....................................................
File packaging/setup/plugins/ovirt-engine-setup/config/ca.py
Line 51:     def _misc(self):
Line 52:         uninstall_files = []
Line 53:         self.environment[
Line 54:             osetupcons.CoreEnv.REGISTER_UNINSTALL_GROUPS
Line 55:         ].addFiles('ca_pki', uninstall_files)
This will throw an exception if PKI files already existed because the function 
where the group is created will not be executed.
Line 56:         self.environment[otopicons.CoreEnv.MAIN_TRANSACTION].append(
Line 57:             filetransaction.FileTransaction(
Line 58:                 name=(
Line 59:                     osetupcons.FileLocations.


--
To view, visit http://gerrit.ovirt.org/14732
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6efe201ed5a9dee7f681ffd61c8f988d24a33a7
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to