Eli Mesika has posted comments on this change.

Change subject: (WIP) Adding caching capabilities to database access
......................................................................


Patch Set 5: (1 inline comment)

lots of comments on prev reviews are still not -answered

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePool.java
Line 12: import org.ovirt.engine.core.compat.NGuid;
Line 13: import org.ovirt.engine.core.compat.Version;
Line 14: 
Line 15: public class StoragePool extends IVdcQueryable implements 
BusinessEntity<Guid> {
Line 16: public class storage_pool extends IVdcQueryable implements 
BusinessEntity<Guid> {
Seems like a wrong merge duplicate the class def , the 1st is the correct one
Line 17:     private static final long serialVersionUID = 6162262095329980112L;
Line 18: 
Line 19:     private Guid id = new Guid();
Line 20: 


--
To view, visit http://gerrit.ovirt.org/14188
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04d7edea6a52626c68f88362416abdb025e4b026
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to