Kanagaraj M has posted comments on this change. Change subject: engine: only supported models should use search paging ......................................................................
Patch Set 3: The approach looks good. A guick scan revealed that there are some popup/dialogs uses SearchQuery to fetch the list of items. We just need to see that they don't have any problems with this change. Also is some places (AsyncDataProvider) we are setting the search limit to 9999 for some of the queries, this looks like an workaround for the bug you trying to address. We need to remove this as well. -- To view, visit http://gerrit.ovirt.org/11061 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I700f088827deec13020dcf57cdadf921cb3eaec7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
