Allon Mureinik has uploaded a new change for review. Change subject: core, webadmin: Move VmValidationUtils ......................................................................
core, webadmin: Move VmValidationUtils This class has no business being in common - it's conceptually part of the bll validation framework, and is indeed only used in bll. Note: As part of the change, its entry was removed from Common.gwt.xml (as bll classes cannot be imported to GWT), with no adverse effect. This only strengthens the point that this class was not supposed to be in common. Change-Id: I506dc65f8740cdc18d57007f46a75d7f89f169b1 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidationUtils.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 3 files changed, 2 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/03/15003/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java index 0043d35..178bdbc 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java @@ -9,6 +9,7 @@ import org.apache.commons.lang.StringUtils; import org.ovirt.engine.core.bll.context.CompensationContext; import org.ovirt.engine.core.bll.network.MacPoolManager; +import org.ovirt.engine.core.bll.validator.VmValidationUtils; import org.ovirt.engine.core.common.backendinterfaces.BaseHandler; import org.ovirt.engine.core.common.businessentities.Disk; import org.ovirt.engine.core.common.businessentities.DiskImage; @@ -32,7 +33,6 @@ import org.ovirt.engine.core.common.utils.Pair; import org.ovirt.engine.core.common.utils.VmDeviceCommonUtils; import org.ovirt.engine.core.common.utils.VmDeviceType; -import org.ovirt.engine.core.common.utils.VmValidationUtils; import org.ovirt.engine.core.common.vdscommands.SetVmStatusVDSCommandParameters; import org.ovirt.engine.core.common.vdscommands.VDSCommandType; import org.ovirt.engine.core.compat.Guid; diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmValidationUtils.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidationUtils.java similarity index 97% rename from backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmValidationUtils.java rename to backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidationUtils.java index 895e44e..77ff4f9 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmValidationUtils.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidationUtils.java @@ -1,4 +1,4 @@ -package org.ovirt.engine.core.common.utils; +package org.ovirt.engine.core.bll.validator; import org.ovirt.engine.core.common.businessentities.VmOsType; import org.ovirt.engine.core.common.config.Config; diff --git a/frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml b/frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml index f170e1f..27a1ff6 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml +++ b/frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml @@ -219,9 +219,6 @@ <!-- UiCommon --> <include name="common/VdcActionUtils.java" /> - <!-- Validations --> - <include name="common/utils/VmValidationUtils.java" /> - <!-- Backend Validation framework --> <include name="common/validation/annotation/HostnameOrIp.java" /> <include name="common/validation/group/**" /> -- To view, visit http://gerrit.ovirt.org/15003 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I506dc65f8740cdc18d57007f46a75d7f89f169b1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
