Shahar Havivi has uploaded a new change for review. Change subject: fndbugs: method contains a redundant check of a null value ......................................................................
fndbugs: method contains a redundant check of a null value findbugs reason: RCN: Redundant nullcheck of value known to be null Change-Id: I9655ef3c2b03ff0b9f6f4da8eaafe275950a6394 Signed-off-by: Shahar Havivi <[email protected]> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/CustomSelectionCell.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/08/15008/1 diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/CustomSelectionCell.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/CustomSelectionCell.java index 5347001..990f63c 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/CustomSelectionCell.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/CustomSelectionCell.java @@ -84,7 +84,7 @@ viewData = null; } - int selectedIndex = getSelectedIndex(viewData == null ? value : viewData); + int selectedIndex = getSelectedIndex(value); if (isEnabled) { sb.appendHtmlConstant("<select class='" + style + "' tabindex=\"-1\">"); //$NON-NLS-1$ //$NON-NLS-2$ } else { -- To view, visit http://gerrit.ovirt.org/15008 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9655ef3c2b03ff0b9f6f4da8eaafe275950a6394 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
