Doron Fediuck has posted comments on this change.
Change subject: engine: watchdog - restapi support
......................................................................
Patch Set 29: (5 inline comments)
Laszlo, please see inline for some missing stuff.
Michael, can you review everything else additionally?
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendWatchdogsResource.java
Line 43: VdcActionType.RemoveWatchdog);
Line 44: }
Line 45:
Line 46: protected boolean matchEntity(VmWatchdog entity, String name) {
Line 47: return false;
This is basically a comparator, but since we're going to have only a single WD
per VM I think it will not be used.
Laszlo?
Line 48: }
Line 49:
Line 50: protected String[] getRequiredAddFields() {
Line 51: return new String[] { "action", "model" };
Line 51: return new String[] { "action", "model" };
Line 52: }
Line 53:
Line 54: protected String[] getRequiredUpdateFields() {
Line 55: return new String[] { "action", "model" };
Laszlo, based on the new CRUD I think it should be possible to update only one
of them. So it should be both or any of them.
Line 56: }
Line 57:
Line 58: protected VdcActionParametersBase getAddParameters(VmWatchdog
entity, WatchDog device) {
Line 59: return new WatchdogParameters();
Line 59: return new WatchdogParameters();
Line 60: }
Line 61:
Line 62: protected VdcActionParametersBase getRemoveParameters(String id) {
Line 63: return new VmOperationParameterBase();
Laszlo, maybe now you need to return something meaningful here using the given
id?
Line 64: }
Line 65:
Line 66: protected ParametersProvider<WatchDog, VmWatchdog>
getUpdateParametersProvider() {
Line 67: return null;
Line 67: return null;
Line 68: }
Line 69:
Line 70: protected <T> boolean matchEntity(VmWatchdog entity, T id) {
Line 71: return false;
Same as the above comparator, will it be used?
Line 72: }
Line 73:
Line 74: protected WatchDog doPopulate(WatchDog model, VmWatchdog entity) {
Line 75: model.setAction(entity.getAction() == null ? null :
entity.getAction().name());
Line 79: }
Line 80:
Line 81: @Override
Line 82: public Response add(Disk device) {
Line 83: return null;
Disk???
Maybe change to watchdog?
What about implementation?
Line 84: }
Line 85:
--
To view, visit http://gerrit.ovirt.org/13060
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief5b20ecf2221faf900cadfeafe4c71607a9eca3
Gerrit-PatchSet: 29
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
