Shahar Havivi has uploaded a new change for review. Change subject: findbugs: ignore: Redundant null check from getConfigValue ......................................................................
findbugs: ignore: Redundant null check from getConfigValue findbugs complains that we are checking ldapPort for null when its not suppose to be null. in this case we are checking for the return value from getConfigValue() and we may have a null value from the Database findbugs reason: RCN: Redundant nullcheck of value known to be non-null Change-Id: If712c28362bae2cfa756c14d8cadf1e96fc3e187 Signed-off-by: Shahar Havivi <[email protected]> --- M backend/manager/tools/exclude-filters.xml 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/19/15019/1 diff --git a/backend/manager/tools/exclude-filters.xml b/backend/manager/tools/exclude-filters.xml index 3234593..e1af053 100644 --- a/backend/manager/tools/exclude-filters.xml +++ b/backend/manager/tools/exclude-filters.xml @@ -11,4 +11,19 @@ <Method name="toString"/> <Bug code="DE"/> </Match> + + <!-- + findbugs complains that we are checking ldapPort for null when its not + suppose to be null. + in this case we are checking for the return value from getConfigValue() + and we may have a null value from the Database + + findbugs reason: + RCN: Redundant nullcheck of value known to be non-null + --> + <Match> + <Class name="org.ovirt.engine.core.domains.ManageDomains" /> + <Method name="createConfigurationProvider"/> + <Bug code="RCN"/> + </Match> </FindBugsFilter> -- To view, visit http://gerrit.ovirt.org/15019 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If712c28362bae2cfa756c14d8cadf1e96fc3e187 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
