Shireesh Anjal has posted comments on this change.
Change subject: gluster: fix forwarding vdsm errors
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java
Line 103: protected void handleVdsErrors(AuditLogType errType, List<String>
errors) {
Line 104: errorType = errType;
Line 105: getReturnValue().getExecuteFailedMessages().addAll(errors);
Line 106:
getReturnValue().getFault().setMessage(StringUtils.join(errors,
SystemUtils.LINE_SEPARATOR));
Line 107: getReturnValue().getFault().setError(null);
I know why we are doing this, but it looks confusing when reading the code.
Feels like we are saying there is no error as we are setting error to null. So
I suggest adding a comment here explaining the purpose of this line.
Line 108: }
Line 109:
Line 110:
Line 111: protected void handleVdsError(AuditLogType errType, String error)
{
Line 111: protected void handleVdsError(AuditLogType errType, String error)
{
Line 112: errorType = errType;
Line 113: getReturnValue().getExecuteFailedMessages().add(error);
Line 114: getReturnValue().getFault().setMessage(error);
Line 115: getReturnValue().getFault().setError(null);
Here as well.
Line 116: }
Line 117:
Line 118: protected boolean updateBrickServerNames(List<GlusterBrickEntity>
bricks, boolean addCanDoActionMessage) {
Line 119: for (GlusterBrickEntity brick : bricks) {
--
To view, visit http://gerrit.ovirt.org/15022
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5df008d6626da5ff0de4ad6231ef65f51e08ec84
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
