Michael Pasternak has posted comments on this change.
Change subject: restapi: Reduce backend calls for DC network list
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworksResource.java
Line 24: extends AbstractBackendNetworksResource
Line 25: implements AssignedNetworksResource {
Line 26:
Line 27: private String clusterId;
Line 28: private
List<org.ovirt.engine.core.common.businessentities.network.Network> networks;
you should not saving state in the resource, but saving this list in the method
doing multiple lookups in to this collection.
Line 29:
Line 30: public BackendClusterNetworksResource(String clusterId) {
Line 31: super(VdcQueryType.GetAllNetworksByClusterId,
Line 32: VdcActionType.AttachNetworkToVdsGroup,
--
To view, visit http://gerrit.ovirt.org/14780
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf65412ace7b5e2da44af9d9288362ab08505129
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
