Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: fixed cpu validation
......................................................................
Patch Set 2: (2 inline comments)
Thanks! just remove the optional...
....................................................
File packaging/setup/plugins/ovirt-engine-setup/all-in-one/cpu.py
Line 108: hardware = util.loadModule(
Line 109:
path=osetupcons.FileLocations.AIO_HOST_DEPLOY_VDSM_PATH,
Line 110: name='hardware'
Line 111: ).Plugin(context=self.context)
Line 112: hardware._validate_virtualization()
again, as far as I read this returns boolean, no?
oh! I meant to use the _isVirtualizationEnabled() and not the wrapper.... but
OK. sorry.
Line 113: hardware._validate_optional()
Line 114: supported = True
Line 115: except ImportError:
Line 116: self.logger.debug("Can't validate virtualization support")
Line 109:
path=osetupcons.FileLocations.AIO_HOST_DEPLOY_VDSM_PATH,
Line 110: name='hardware'
Line 111: ).Plugin(context=self.context)
Line 112: hardware._validate_virtualization()
Line 113: hardware._validate_optional()
you don't need the optional it is pure legacy.
Line 114: supported = True
Line 115: except ImportError:
Line 116: self.logger.debug("Can't validate virtualization support")
Line 117: except Exception as e:
--
To view, visit http://gerrit.ovirt.org/15013
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c19c1d6bf80c0d5f54105f785d97ba7b203cccc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
