Laszlo Hornyak has posted comments on this change.
Change subject: findbugs: Fix fingbugs error in SanTargetModel class
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanTargetModel.java
Line 139:
Line 140: static
Line 141: {
Line 142: loggedInEventDefinition = new EventDefinition("LoggedIn",
SanTargetModel.class); //$NON-NLS-1$
Line 143: }
I agree that the code is kind of strange (may be a leftover from automatic code
generator) but the fix looks OK. Let's go ahead and we can remove the static
initializers later.
Line 144:
Line 145: public SanTargetModel()
Line 146: {
Line 147: setLoggedInEvent(new Event(loggedInEventDefinition));
--
To view, visit http://gerrit.ovirt.org/14456
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4a4fd6bb5b2743d0dc939751d31f5247de6fc7f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
