Alissa Bonas has posted comments on this change.
Change subject: engine: Remove Guid query parameters containers
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(2 inline comments)
good change, a patch a bit too big - hard to review :)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllDisksByVmIdQuery.java
Line 12: import org.ovirt.engine.core.common.queries.IdQueryParameters;
Line 13: import org.ovirt.engine.core.common.utils.VmDeviceType;
Line 14: import org.ovirt.engine.core.compat.Guid;
Line 15:
Line 16: public class GetAllDisksByVmIdQuery<P extends IdQueryParameters>
extends QueriesCommandBase<P> {
If most of the classes receive IdQueryParameters, and only 2 kinds of param
classes extend it in 2 very specific places, why is there still a need in the P
extends IdQueryParameters?
Line 17: public GetAllDisksByVmIdQuery(P parameters) {
Line 18: super(parameters);
Line 19: }
Line 20:
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/adbroker/DirectorySearcherTest.java
Line 32:
Line 33: /**
Line 34: * Tests GetRootDSE functionality In this test it is checked how
GetRootDSE handles a various scenarios *
Line 35: */
Line 36: @Ignore
why ignore this test? noone will fix it that way...
Line 37: public class DirectorySearcherTest extends AbstractLdapTest {
Line 38:
Line 39: @ClassRule
Line 40: public static MockConfigRule mcr = new MockConfigRule(
--
To view, visit http://gerrit.ovirt.org/15017
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I636818d92b87cdb40cb745f28b049d4bd7cabec7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
