Alona Kaplan has posted comments on this change.
Change subject: webadmin: Added validation to ProviderModel
......................................................................
Patch Set 10: Looks good to me, approved
(1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/UrlValidation.java
Line 12:
Line 13: public UrlValidation(String[] allowedSchemes) {
Line 14: if (allowedSchemes == null) {
Line 15: this.allowedSchemes.add(new String());
Line 16: } else for (String scheme : allowedSchemes) {
Please format this code correctly.
Enter and { after else.
Line 17: this.allowedSchemes.add(scheme.toLowerCase());
Line 18: }
Line 19: }
Line 20:
--
To view, visit http://gerrit.ovirt.org/14695
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I754a7ce4e2aa719b0284d2dc0021822af2629b07
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
