Michael Pasternak has posted comments on this change. Change subject: restapi: introducing virtio-scsi support ......................................................................
Patch Set 3: (1 inline comment) .................................................... File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd Line 2405: <xs:element name="statistics" type="Statistics" minOccurs="0" maxOccurs="1"/> Line 2406: <xs:element name="active" type="xs:boolean" minOccurs="0"/> Line 2407: <xs:element ref="quota" minOccurs="0" maxOccurs="1"/> Line 2408: <xs:element name="lun_storage" type="Storage" minOccurs="0"/> Line 2409: <xs:element name="sgio" type="xs:string" minOccurs="0"/> if no other options exist besides filtered|unfiltered, i'd suggest using <sgio_filtered>true|false<sgio_filtered/> instead, this modelling reduces the complexity of this property and knowing ahead possible values for it Line 2410: </xs:sequence> Line 2411: </xs:extension> Line 2412: </xs:complexContent> Line 2413: </xs:complexType> -- To view, visit http://gerrit.ovirt.org/14907 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8fdf89d826144885bcffd8ee29798102fcaceb44 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
