Vered Volansky has posted comments on this change.

Change subject: findbugs: comparing two different types
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetWatchdogQueryTest.java
Line 61: 
Line 62:         query.executeQueryCommand();
Line 63:         Assert.assertNotNull(query.getReturnValue());
Line 64:         
Assert.assertEquals((((VmWatchdog)query.getReturnValue()).getAction()).name().toLowerCase(),
 "reset");
Line 65:         
Assert.assertEquals((((VmWatchdog)query.getReturnValue()).getModel()).name().toLowerCase(),
 "i6300esb");
Should also be fixed in line 45, sorry for the ping-pong...
Line 66:     }
Line 67: 


--
To view, visit http://gerrit.ovirt.org/15065
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5d76c345e7a0f9c08e03c9b60fbcdd9fc1a4467
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to