Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: ignore: add ignore for super.clone from VDS.clone method ......................................................................
findbugs: ignore: add ignore for super.clone from VDS.clone method findbugs complains that VDS clone() method is not calling it super class clone() method. we cannot call super.close() because this code compile to GWT as well, and GWT does not support CloneNotSupportedException which is thrown when adding this code. findbugs reason: CN: clone method does not call super.clone() (CN_IDIOM_NO_SUPER_CALL) Change-Id: I9954242e24851df299c0d4d74f6466a66327120f Signed-off-by: Shahar Havivi <[email protected]> --- A backend/manager/modules/common/exclude-filters.xml M backend/manager/modules/common/pom.xml 2 files changed, 29 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15083 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9954242e24851df299c0d4d74f6466a66327120f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
