Maor Lipchuk has posted comments on this change. Change subject: core: compensate to unknown status ......................................................................
Patch Set 2: Looks good to me, but someone else must approve (2 inline comments) .................................................... Commit Message Line 6: Line 7: core: compensate to unknown status Line 8: Line 9: On deactivate storage domain command, the storage domain(s) status is being Line 10: saved in the compensation context so that in case of failure - it will /s/so that in case/so in case Line 11: be reverted to it's original value. Line 12: Line 13: In case of failure when executing DeactiveStorageDomainVDSCommand this failure Line 14: will propagate to DeactiveStorageDomainCommand and will cause to the compensation Line 7: core: compensate to unknown status Line 8: Line 9: On deactivate storage domain command, the storage domain(s) status is being Line 10: saved in the compensation context so that in case of failure - it will Line 11: be reverted to it's original value. /s/to it's/to its Line 12: Line 13: In case of failure when executing DeactiveStorageDomainVDSCommand this failure Line 14: will propagate to DeactiveStorageDomainCommand and will cause to the compensation Line 15: saved data to be applied - which might override the changed statuses and return the -- To view, visit http://gerrit.ovirt.org/14767 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f8a27cbac711fa87db408a06fe22a7b3e9b2da9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
