Shubhendu Tripathi has posted comments on this change.

Change subject: gluster: Command to update gluster hook on servers
......................................................................


Patch Set 3: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File 
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
Line 2284:     @Constants.DefaultStringValue("Failed to run LDAP query, please 
check server logs for more info.")
Line 2285:     String FAILED_TO_RUN_LDAP_QUERY();
Line 2286: 
Line 2287:     @DefaultStringValue("Cannot ${action} ${type}. There are no 
conflicting servers to update hook.")
Line 2288:     String ACTION_TYPE_FAILED_GLUSTER_HOOK_NO_CONFLICT_SERVERS();
In agreement with Kanagaraj's comments


--
To view, visit http://gerrit.ovirt.org/14935
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibccccbbed1e07d471dc472c41843f46767b9e083
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to