Mike Kolesnik has posted comments on this change.
Change subject: engine: Add new parameter class for CollectNetworkData
......................................................................
Patch Set 4: (2 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/CollectVdsNetworkDataVDSCommandParameters.java
Line 16: }
Line 17:
Line 18: @Override
Line 19: public String toString() {
Line 20: return String.format("%s, skipMgmtNetwork=%s",
super.toString(), Boolean.valueOf(skipMgmtNetwork()));
I think Boolean.valueOf() is redundant here since it's a primitive field, don't
you agree?
Line 21: }
Line 22:
Line 23: public boolean skipMgmtNetwork() {
Line 24: return skipMgmtNetwork;
Line 19: public String toString() {
Line 20: return String.format("%s, skipMgmtNetwork=%s",
super.toString(), Boolean.valueOf(skipMgmtNetwork()));
Line 21: }
Line 22:
Line 23: public boolean skipMgmtNetwork() {
This is unconventional naming, perhaps should be named something like
isManagementNetworkSkipped()?
Line 24: return skipMgmtNetwork;
Line 25: }
Line 26:
Line 27: public void setSkipMgmtNetwork(boolean skipMgmtNetwork) {
--
To view, visit http://gerrit.ovirt.org/14999
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If6986cc378e7d36213da9cb200e8a6098b0d604f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
