Alissa Bonas has posted comments on this change.
Change subject: core: improve CDA of AddStorageServerConnection
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java
Line 76: return
failCanDoAction(VdcBllMessages.VALIDATION_STORAGE_CONNECTION_EMPTY_VFSTYPE);
Line 77: }
Line 78:
Line 79: if (getParameters().getVdsId().equals(Guid.Empty)) {
Line 80: if (!InitializeVds()) {
Done
Line 81: return false;
Line 82: }
Line 83: } else if (getVds() == null) {
Line 84: return
failCanDoAction(VdcBllMessages.VDS_INVALID_SERVER_ID);
....................................................
Commit Message
Line 5: CommitDate: 2013-05-28 13:48:47 +0300
Line 6:
Line 7: core: improve CDA of AddStorageServerConnection
Line 8:
Line 9: Improve canDoACtion of AddStorageServerConnectionCommand
the method name is canDoAction, not CanDoAction :)
Line 10: to have early returns in failures, and call to its super.canDoAction
Line 11: since there are checks that are done there and
Line 12: are not done by the overriding command.
Line 13:
--
To view, visit http://gerrit.ovirt.org/15126
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I00a46aac7d642128c287ef633c492f3c1b85f572
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
