Frank Kobzik has posted comments on this change.
Change subject: engine: Integrate noVNC support
......................................................................
Patch Set 8: (1 inline comment)
....................................................
File packaging/services/ovirt-websocket-proxy.py
Line 48: Called after a new WebSocket connection has been established.
Line 49: """
Line 50: connection_data =
self._ticketDecoder.decode(self.path[1:]).split(':')
Line 51: target_host = connection_data[0].encode('utf8')
Line 52: target_port = connection_data[1].encode('utf8')
Note I need to do this here, the type of connection_data[x] is unicode.
Line 53:
Line 54: # Connect to the target
Line 55: self.msg("connecting to: %s:%s" % (
Line 56: target_host, target_port))
--
To view, visit http://gerrit.ovirt.org/13931
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I44e9870b88537360a1886e89c08f18865eae2ef0
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Martin Beták <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
