Shahar Havivi has uploaded a new change for review. Change subject: findbugs: ignore: absolute pathname in test case ......................................................................
findbugs: ignore: absolute pathname in test case findbugs complain that the code is using absolute path in File object, the FileServletTest is using it to test input path findbugs reason: DMI: Code contains a hard coded reference to an absolute pathname (DMI_HARDCODED_ABSOLUTE_FILENAME) Change-Id: Ic14b42211fbae45408f78e1efeb148bd1b0dba45 Signed-off-by: Shahar Havivi <[email protected]> --- A backend/manager/modules/root/exclude-filters.xml M backend/manager/modules/root/pom.xml 2 files changed, 26 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/56/15156/1 diff --git a/backend/manager/modules/root/exclude-filters.xml b/backend/manager/modules/root/exclude-filters.xml new file mode 100644 index 0000000..47d52c3 --- /dev/null +++ b/backend/manager/modules/root/exclude-filters.xml @@ -0,0 +1,14 @@ +<FindBugsFilter> + <!-- + findbugs complain that the code is using absolute path in File object, + the FileServletTest is using it to test input path + + findbugs reason: + DMI: Code contains a hard coded reference to an absolute pathname (DMI_HARDCODED_ABSOLUTE_FILENAME) + --> + <Match> + <Class name="org.ovirt.engine.core.FileServletTest" /> + <Method name="testInitServletConfig_BaseSet"/> + <Bug code="DMI"/> + </Match> + </FindBugsFilter> diff --git a/backend/manager/modules/root/pom.xml b/backend/manager/modules/root/pom.xml index ca2e027..4802846 100644 --- a/backend/manager/modules/root/pom.xml +++ b/backend/manager/modules/root/pom.xml @@ -83,6 +83,18 @@ </configuration> </plugin> + <plugin> + <groupId>org.codehaus.mojo</groupId> + <artifactId>findbugs-maven-plugin</artifactId> + <version>${findbugs.version}</version> + <configuration> + <xmlOutput>true</xmlOutput> + <!-- Optional directory to put findbugs xdoc xml report --> + <excludeFilterFile>exclude-filters.xml</excludeFilterFile> + <xmlOutputDirectory>target/site</xmlOutputDirectory> + </configuration> + </plugin> + </plugins> </build> -- To view, visit http://gerrit.ovirt.org/15156 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic14b42211fbae45408f78e1efeb148bd1b0dba45 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
