Martin Beták has posted comments on this change.
Change subject: webadmin: Correct timezone default in New/Edit VM dialog
......................................................................
Patch Set 3: (3 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/TimeZoneType.java
Line 3: public enum TimeZoneType {
Line 4: WINDOWS_TIMEZONE,
Line 5: GENERAL_TIMEZONE;
Line 6:
Line 7: public static TimeZoneType getTimeZoneByOs(boolean windows) {
Done
Line 8: return windows ? WINDOWS_TIMEZONE : GENERAL_TIMEZONE;
Line 9: }
Line 10:
Line 11: public boolean isWindowsTimeZone() {
Line 7: public static TimeZoneType getTimeZoneByOs(boolean windows) {
Line 8: return windows ? WINDOWS_TIMEZONE : GENERAL_TIMEZONE;
Line 9: }
Line 10:
Line 11: public boolean isWindowsTimeZone() {
Well not sure if I remember correctly but different versions of windows support
different set of timezones so I wanted to make the code extensible just in
case. Anyway it turns out that this method is no longer required so I will
simply get rid of it.
Line 12: switch (this) {
Line 13: case WINDOWS_TIMEZONE:
Line 14: return true;
Line 15:
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java
Line 99:
Line 100: @DefaultMessage("default [{0}]")
Line 101: String globalVncKeyboardLayoutCaption(String currentDefault);
Line 102:
Line 103: @DefaultMessage("default: {0}")
Yes I thought about that but the problem is that we wanted to display the []
decoration around keyboard layout: e.g. [en-us] and this was not appropriate
for timezone value which is much longer and already surrounded in ()
Line 104: String defaultTimeZoneCaption(String currentDefault);
--
To view, visit http://gerrit.ovirt.org/14248
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaccb31f5634c16583004a79b9b47b83ff994088a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Beták <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Martin Beták <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
