Shahar Havivi has uploaded a new change for review. Change subject: findbugs: multiplication result int when long expected ......................................................................
findbugs: multiplication result int when long expected findbugs reason: ICAST: Result of integer multiplication cast to long (ICAST_INTEGER_MULTIPLY_CAST_TO_LONG) Change-Id: Ibf362f4d9ed811034238c58617e897a137037027 Signed-off-by: Shahar Havivi <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCpuVdsLoadBalancingAlgorithm.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/TimeSpan.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 3 files changed, 8 insertions(+), 8 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/60/15160/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCpuVdsLoadBalancingAlgorithm.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCpuVdsLoadBalancingAlgorithm.java index c7db4bf..cb7f868 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCpuVdsLoadBalancingAlgorithm.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCpuVdsLoadBalancingAlgorithm.java @@ -35,8 +35,8 @@ public boolean eval(VDS p) { return p.getUsageCpuPercent() >= p.getHighUtilization() && p.getCpuOverCommitTimestamp() != null - && (new Date().getTime() - p.getCpuOverCommitTimestamp().getTime()) >= p - .getCpuOverCommitDurationMinutes() * 1000 * 60; + && (new Date().getTime() - p.getCpuOverCommitTimestamp().getTime()) >= (long)p + .getCpuOverCommitDurationMinutes() * 1000L * 60L; } }); @@ -102,8 +102,8 @@ public boolean eval(VDS p) { return p.getUsageCpuPercent() <= p.getLowUtilization() && p.getCpuOverCommitTimestamp() != null - && (new Date().getTime() - p.getCpuOverCommitTimestamp().getTime()) >= p - .getCpuOverCommitDurationMinutes() * 60 * 1000; + && (new Date().getTime() - p.getCpuOverCommitTimestamp().getTime()) >= (long)p + .getCpuOverCommitDurationMinutes() * 60L * 1000L; } }); // The order of sorting will be from smallest to biggest. The vm will be diff --git a/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/TimeSpan.java b/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/TimeSpan.java index f726084..0c157e8 100644 --- a/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/TimeSpan.java +++ b/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/TimeSpan.java @@ -41,9 +41,9 @@ public TimeSpan(int days, int hours, int minutes, int seconds, int milliseconds) { TotalMilliseconds = milliseconds; TotalMilliseconds += seconds * MS_PER_SECOND; - TotalMilliseconds += minutes * MS_PER_MINUTE; - TotalMilliseconds += hours * MS_PER_HOUR; - TotalMilliseconds += days * MS_PER_DAY; + TotalMilliseconds += (long)minutes * (long)MS_PER_MINUTE; + TotalMilliseconds += (long)hours * (long)MS_PER_HOUR; + TotalMilliseconds += (long)days * (long)MS_PER_DAY; computeProperties(); } diff --git a/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java b/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java index a464f46..7f1be6c 100644 --- a/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java +++ b/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java @@ -406,7 +406,7 @@ model.setDomain(domain); } MemoryPolicy policy = new MemoryPolicy(); - policy.setGuaranteed(Long.valueOf(entity.getMinAllocatedMem() * BYTES_PER_MB)); + policy.setGuaranteed((long)entity.getMinAllocatedMem() * (long)BYTES_PER_MB); model.setMemoryPolicy(policy); model.setTimezone(TimeZoneMapping.getJava(entity.getTimeZone())); if (!StringUtils.isEmpty(entity.getCustomProperties())) { -- To view, visit http://gerrit.ovirt.org/15160 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibf362f4d9ed811034238c58617e897a137037027 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
