Tomas Jelinek has posted comments on this change.
Change subject: webadmin: [WIP] preview snapshot with memory popup
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotPreviewPopupWidget.ui.xml
Line 16: margin-right: 5px;
Line 17: }
Line 18: </ui:style>
Line 19:
Line 20: <g:VerticalPanel verticalAlignment="ALIGN_MIDDLE"
addStyleNames="{style.content}">
If it is possible please always avoid using Vertical/HorizontalPanels. They
render as HTML tables which should be avoided. The preferred option is to use
FlowPanel which renders as div.
Line 21: <g:Label ui:field="messageLabel"
addStyleNames="{style.messageLabel}" />
Line 22: <e:EntityModelCheckBoxEditor ui:field="memoryEditor"
addStyleNames="{style.memoryEditor}" />
Line 23: </g:VerticalPanel>
Line 24:
--
To view, visit http://gerrit.ovirt.org/14868
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I48fc8f501286d898d54a9c7357ccf0934c9ed1d8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
