Liron Ar has uploaded a new change for review. Change subject: webadmin: avoid multiple failovers caused by import subtabs auto-refresh ......................................................................
webadmin: avoid multiple failovers caused by import subtabs auto-refresh The SubTabStorageTemplateBackupView/SubTabStorageVmBackupView subtabs executes an engine query to display the vms/templates that exist on the selected export domain - this engine query executes an spm command (GetVmsInfoVDSCommand) which will attempt to perform failover in case of failure. The fact that the query is being executed every 5 seconds, causes to the requests to "pile up" and possibly perform multiple failovers, Therefore the automatic refresh to the tab has been replaced with manual refresh button. Change-Id: I2668a60b5b33b2ca8d82b9d08c477ba7c1a3a723 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=958766 Signed-off-by: Liron Aravot <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageTemplateBackupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageVmBackupView.java 3 files changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/94/15194/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java index 202ba82..569e89d 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java @@ -74,6 +74,7 @@ setHashName("vm_import"); // //$NON-NLS-1$ setAppListModel(new VmAppListModel()); + setIsTimerDisabled(true); } @Override diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageTemplateBackupView.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageTemplateBackupView.java index 1835e46..1fcf369 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageTemplateBackupView.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageTemplateBackupView.java @@ -111,6 +111,8 @@ return getDetailModel().getRemoveCommand(); } }); + + getTable().showRefreshButton(); } } diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageVmBackupView.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageVmBackupView.java index e3af215..0e34eba 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageVmBackupView.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageVmBackupView.java @@ -150,6 +150,8 @@ return getDetailModel().getRemoveCommand(); } }); + + getTable().showRefreshButton(); } private void initApplicationsTable(ApplicationConstants constants) { -- To view, visit http://gerrit.ovirt.org/15194 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2668a60b5b33b2ca8d82b9d08c477ba7c1a3a723 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
