Liron Ar has posted comments on this change.
Change subject: core: display actual information through
GetUnregisteredDiskQuery
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterDiskCommand.java
Line 73: storageIds.add(getParameters().getStorageDomainId());
Line 74: newDiskImage.setStorageIds(storageIds);
Line 75: // The disk image won't have an interface set on it. Set it to
IDE by default. When the
Line 76: // disk is attached to a VM, its interface can be changed to
the appropriate value for that VM.
Line 77: newDiskImage.setDiskInterface(DiskInterface.IDE);
this has just been moved from the query to keep the functionality as is, it can
always be deleted ;)
Line 78:
newDiskImage.setStoragePoolId(getParameters().getStoragePoolId());
Line 79: }
Line 80:
Line 81: protected static String
generateDefaultAliasForRegiteredDisk(Calendar time) {
....................................................
Commit Message
Line 10: in this patch the actual information is displayed, while the needed
Line 11: information is being set when registering the disk.
Line 12:
Line 13: Change-Id: I5e372ea6efec819c1dd582b7e8db9ce579a0ecef
Line 14: Bug-Url: https://bugzilla.redhat.com/??????
Done
--
To view, visit http://gerrit.ovirt.org/15211
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e372ea6efec819c1dd582b7e8db9ce579a0ecef
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Chris Morrissey <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
