Kanagaraj M has posted comments on this change.

Change subject: gluster: Reset statusconflict flag on enable/disable
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHookStatusChangeCommand.java
Line 54:     }
Line 55: 
Line 56:     @Override
Line 57:     protected boolean canDoAction() {
Line 58:         if (!super.canDoAction()) {
super method GlusterCommandBase.canDoAction() will return false. vdsGroupId is 
null here, so getUpServer() will return null.
Line 59:             return false;
Line 60:         }
Line 61: 
Line 62:         if (getAllUpServers() == null || getAllUpServers().isEmpty()) {


--
To view, visit http://gerrit.ovirt.org/15242
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9913900175e0f5be33bb1ec45b882e770a09fde4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to