Martin Peřina has posted comments on this change.
Change subject: engine: Fix for RHBZ#968958 - Refactor unnecessary while loop
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/JndiAction.java
Line 111: userGuid.append(guid);
Line 112: logQueryContext(userGuid.toString(),
uri.toString(), currentLdapServer);
Line 113: return AuthenticationResult.OK;
Line 114: }
Line 115: } else {
Isn't the else statement misplaces based upon previous code logic?
if (answer.hasMoreElements()) {
// Print the objectGUID for the user as well as URI and query path
String guid = guidFromResults(answer.next());
if (guid != null) {
userGuid.append(guid);
logQueryContext(userGuid.toString(), uri.toString(), currentLdapServer);
return AuthenticationResult.OK;
} else {
// Print user GUID and another logging info only if it was not printed
previously already
logQueryContext(userGuid.toString(), uri.toString(), currentLdapServer);
}
}
System.out.println("No user in Directory was found for " + userName
+ ". Trying next LDAP server in list");
Line 116: // Print user GUID and another logging info only
if it was not printed previously already
Line 117: logQueryContext(userGuid.toString(),
uri.toString(), currentLdapServer);
Line 118: }
Line 119: System.out.println("No user in Directory was
found for " + userName
--
To view, visit http://gerrit.ovirt.org/15217
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I938726d631ac4ccb91cc68791e8e349dd43895ea
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomáš Došek <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
