Michal Skrivanek has posted comments on this change.
Change subject: novnc: support SIGTERM at websockify service
......................................................................
Patch Set 2: (3 inline comments)
....................................................
File packaging/services/ovirt-websocket-proxy.py
Line 161: record = False # translate to boolean
Line 162:
Line 163: #
Line 164: # WORKAROUND-BEGIN
Line 165: # set temrinate exception as
"terminate"
Line 166: # the websockify library assumes interactive
Line 167: # mode only (SIGINT).
Line 168: # it also expect exit at the middle of procesing.
Line 169: # so we comply.
Line 164: # WORKAROUND-BEGIN
Line 165: # set temrinate exception as
Line 166: # the websockify library assumes interactive
Line 167: # mode only (SIGINT).
Line 168: # it also expect exit at the middle of procesing.
"processing"
Line 169: # so we comply.
Line 170: def myterm(signo, frame):
Line 171: sys.exit(0)
Line 172: oldterm = signal.getsignal(signal.SIGTERM)
Line 199: wrap_cmd=None
Line 200: ).start_server()
Line 201: # WORKAROUND-BEGIN
Line 202: # websockify exit because of signals.
Line 203: # redurect it to expected termination sequence.
"redirect"
Line 204: except SystemExit:
Line 205: self.logger.debug('SystemExit', exc_info=True)
Line 206: raise Service.TerminateException()
Line 207: finally:
--
To view, visit http://gerrit.ovirt.org/15201
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4062fe348c2a1a1735e932884c8011ef66720bf6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eyal Edri <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
