Shahar Havivi has uploaded a new change for review. Change subject: findbugs: Random object recreated each call ......................................................................
findbugs: Random object recreated each call for better random use the same object instead of creating a new one. findbugs reason: DMI: Random object created and used only once (DMI_RANDOM_USED_ONLY_ONCE) Change-Id: I4d88d7c80698e6d0ec1fed9ba8cb78c2b524ebae Signed-off-by: Shahar Havivi <[email protected]> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/TicketUtils.java 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/71/15271/1 diff --git a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/TicketUtils.java b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/TicketUtils.java index 8cd1e4d..034e91b 100644 --- a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/TicketUtils.java +++ b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/TicketUtils.java @@ -31,6 +31,7 @@ PrivateKey key; private final int lifetime; + protected Random random = new Random(); /** * Creates a TicketUtils instance for @@ -82,7 +83,7 @@ * Add signed fields */ byte[] random = new byte[8]; - new Random().nextBytes(random); + this.random.nextBytes(random); map.put("salt", base64.encodeToString(random)); SimpleDateFormat df = new SimpleDateFormat("yyyyMMddHHmmss"); -- To view, visit http://gerrit.ovirt.org/15271 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4d88d7c80698e6d0ec1fed9ba8cb78c2b524ebae Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
