Allon Mureinik has posted comments on this change. Change subject: core: Fix quota count for Template with multiple SD ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java Line 294: disk.getQuotaId(), Line 295: null, Line 296: QuotaStorageConsumptionParameter.QuotaAction.RELEASE, Line 297: disk.getStorageIds().get(0), Line 298: (double) disk.getSizeInGigabytes() * disk.getStorageIds().size())); I don't understand this patch. You create a QuotaStorageConsumptionParameter with the ID of the first storage domain, but demand the size you take up on ALL the domains. Line 299: } Line 300: } Line 301: } Line 302: return list; -- To view, visit http://gerrit.ovirt.org/15278 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2f5051218405753dc86b997aaa47f488f159350 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: ofri masad <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
